jdormit/activitypub-php
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Leverage the totalItems field for O(1) collection adding if present

Browse Source
This commit is contained in:
Jeremy Dormitzer 2019-03-02 17:23:53 -05:00
parent 15dd5d3e9f
commit d5cdb06dc7
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Objects/CollectionsService.php
View File

@ -283,9 +283,14 @@ class CollectionsService
if ( !$items instanceof ActivityPubObject ) { if ( !$items instanceof ActivityPubObject ) {
throw new Exception( 'Attempted to add an item to a collection with a non-object items field' ); throw new Exception( 'Attempted to add an item to a collection with a non-object items field' );
} }
// This is making the assumption that $items *only* contains numeric fields (i.e., it is an array) if ( $collection->hasField( 'totalItems' ) && is_numeric( $collection['totalItems'] ) ) {
// Also, it's O(n) on the size of the collection // This will break if some other server puts in an incorrect value for totalItems
$itemCount = count( $items->getFields() ); $itemCount = intval( $collection['totalItems'] );
} else {
// This is making the assumption that $items *only* contains numeric fields (i.e., it is an array)
// Also, it's O(n) on the size of the collection
$itemCount = count( $items->getFields() );
}
if ( is_array( $item ) ) { if ( is_array( $item ) ) {
$item = $this->objectsService->persist( $item, 'collections-service.add' ); $item = $this->objectsService->persist( $item, 'collections-service.add' );
$newItemField = Field::withObject( $newItemField = Field::withObject(